Review Request 126843: Make kwallet-pam usable outside of Plasma

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126843/#review91599
-----------------------------------------------------------


Ship it!




Looks good to me, thanks!

- Martin Klapetek


On Jan. 25, 2016, 8:48 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126843/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 8:48 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> -------
> 
> Currently, kwallet-pam is only usable when used in combination with plasma5, becaue the code that connects PAM created socket to kwalletd is in startkde script.
> 
> Move that code into kwallet-pam itself and add an autostart desktop file so it can be used in plasma and outside of plasma (ie, gnome). Also add a check for socat executable, which is required to connect to the socket.
> 
> v2: Incorporate changes mentioned by Martin, remove CMake version requirement increase.
> 
> I tried using feature summary, but it wouldn't fail when I remove the executable.
> 
> v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for extra-cmake-modules, which is now being used by this package.
> 
> v4: Removed OnlyShownIn line from the desktop file as suggested by Xuetian and Martin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8bd526e 
>   pam_kwallet_init PRE-CREATION 
>   pam_kwallet_init.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126843/diff/
> 
> 
> Testing
> -------
> 
> Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160125/9a30af73/attachment.html>