Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Lamarque Souza]

> On Jan. 15, 2016, 4:04 p.m., Lamarque Souza wrote:
> > kded/notification.cpp, line 56
> > <https://git.reviewboard.kde.org/r/126748/diff/2/?file=430946#file430946line56>
> >
> >     It would be safer to add an inhibit to guarantee onPrepareForSleep() has finished before letting NetworkManager to continue to sleep. On the other hand, onPrepareForSleep() is simple code and can finish very fast, maybe an inhibit is a bit overkill, who knows?
> 
> Kai Uwe Broulik wrote:
>     I think it's a bit of an overkill to have this. Also I don't want to unneccessarily delay suspending just because of a convenience feature like this.

Ok then. Ship it.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91153
-----------------------------------------------------------


On Jan. 15, 2016, 3:03 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 3:03 p.m.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> It's quite natural that the connection goes away when we're about to suspend :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -----
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> -------
> 
> While I still think Plasma-NM is waaaaaay too verbose about everything, at least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160125/ae045e88/attachment.html>