Review Request 126843: Make kwallet-pam usable outside of Plasma

[Martin Gräßlin]

> On Jan. 22, 2016, 10:33 p.m., Xuetian Weng wrote:
> > pam_kwallet_init.desktop.cmake, line 7
> > <https://git.reviewboard.kde.org/r/126843/diff/3/?file=435311#file435311line7>
> >
> >     Why limit to these desktop anyway? I don't see why this is necessary. (e.g. why not lxqt?)
> 
> Armin K. wrote:
>     Hmm, I copied that line from baloo_file.desktop. I suppose it should be safe to remove it entirely, no?

yes, please remove. It makes sense in the case of baloo, but not so much in this case (especially as it's going to autostart anyway).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126843/#review91457
-----------------------------------------------------------


On Jan. 22, 2016, 8:08 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126843/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 8:08 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> -------
> 
> Currently, kwallet-pam is only usable when used in combination with plasma5, becaue the code that connects PAM created socket to kwalletd is in startkde script.
> 
> Move that code into kwallet-pam itself and add an autostart desktop file so it can be used in plasma and outside of plasma (ie, gnome). Also add a check for socat executable, which is required to connect to the socket.
> 
> v2: Incorporate changes mentioned by Martin, remove CMake version requirement increase.
> 
> I tried using feature summary, but it wouldn't fail when I remove the executable.
> 
> v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for extra-cmake-modules, which is now being used by this package.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8bd526e 
>   pam_kwallet_init PRE-CREATION 
>   pam_kwallet_init.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126843/diff/
> 
> 
> Testing
> -------
> 
> Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160125/a10d40ee/attachment-0001.html>