Review Request 126879: [digital-clock] Use iso-codes for country names

[Pino Toscano]

> On Gen. 24, 2016, 10:39 p.m., David Edmundson wrote:
> > applets/digital-clock/plugin/timezonesi18n.cpp, line 517
> > <https://git.reviewboard.kde.org/r/126879/diff/1/?file=439603#file439603line517>
> >
> >     may as well keep the comment from the i18n?

Not sure what you mean. The point here is load the translations from the iso_3166 domain (the .mo file, basically), and they have no context there. After this patch, there will be 247 strings less to translate in the digital clock messages, they won't be extracted anymore.


- Pino


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91552
-----------------------------------------------------------


On Gen. 24, 2016, 9:58 p.m., Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> -----------------------------------------------------------
> 
> (Updated Gen. 24, 2016, 9:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Instead of an hardcoded list of translations of country names, look them up in the iso_3166 domain, provided by iso-codes.  The names of countries are changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime dependency.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/plugin/CMakeLists.txt c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> -------
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160124/14c63454/attachment.html>