Review Request 126688: RFC: [Device Notifier] Provide inline feedback

[Kai Uwe Broulik]

> On Jan. 24, 2016, 10:26 nachm., Antonis Geralis wrote:
> > Hello! There is a typo in file ksolidnotify.cpp:166, also shown in third screenshot.

Well spotted. Fixed, thanks.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review91550
-----------------------------------------------------------


On Jan. 24, 2016, 9:40 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 9:40 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Instead of showing a detached status bar with the device name, show the message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely remove this device" message will show up; after 5 seconds the message and the device will disappear. When trying to unmount a device and it fails, device notifier will show up with an error message that will stay there until device notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications engine's wording (I'm open to better verbalizations) and one for the device notifier
> 
> 
> Diffs
> -----
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> -------
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section thing gets confused when the one item is already gone in the model (looks like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device there
> - it cannot actually highlight the device that was safely removed (it's no longer part of the model and thus has no index), we could do a hack for this though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon but the error thing is always red, there's a smaller variant for the former but not the latter apparently, also it seems we lack a proper "task done" icon, Oxygen had one
> 
> 
> File Attachments
> ----------------
> 
> Failed to mount
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> Emblem icon
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png
> Emblem-error
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png
> emblem-information
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160124/0868b28a/attachment-0001.html>