Review Request 126740: Add a script for optimizing svgs

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91416
-----------------------------------------------------------




optimize.svg.sh (line 1)
<https://git.reviewboard.kde.org/r/126740/#comment62489>

    won't work on BSD (/usr/local/bin/bash)
    
    /usr/bin/env bash should work everywhere



optimize.svg.sh (line 4)
<https://git.reviewboard.kde.org/r/126740/#comment62487>

    if command -v svgo >/dev/null; then



optimize.svg.sh (line 14)
<https://git.reviewboard.kde.org/r/126740/#comment62488>

    Paths with spaces will break this.
    
    ```
    find . -name "*.svg" -size 4k -print0 | while IFS= read -r -d '' file; do
        svgo -i $file -o $file $ARGS
    done
    ```
    
    (http://mywiki.wooledge.org/BashFAQ/001)



optimize.svg.sh (line 16)
<https://git.reviewboard.kde.org/r/126740/#comment62491>

    Here an everywhere else
    $v -> "$v" https://github.com/koalaman/shellcheck/wiki/SC2086



optimize.svg.sh (line 20)
<https://git.reviewboard.kde.org/r/126740/#comment62490>

    spaces in a parent dir will break this loop


- Alex Richardson


On Jan. 19, 2016, 10:54 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 10:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> -------
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea that right now we're serving right away the svg's from inkscape and there's room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's interested. In fact, we used to use svgz for the icons, I wonder why that changed. 
> 
> This will change the files in-place rather than as a build step, which is what I considered first. The process to run svgo on every file was about 30 minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, which is a bottle-neck we have.
> 
> 
> Diffs
> -----
> 
>   optimize.svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> -------
> 
> ```
> kde-devel at oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M     icons
> 32M     icons-dark/
> 
> #run the script
> 
> kde-devel at oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M     icons
> 17M     icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160121/94dbeada/attachment.html>