Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

[Marco Martin]

> On Jan. 20, 2016, 10:26 p.m., Hrvoje Senjan wrote:
> > so i lost kmail icon in tray after this it seems

do you have an empty space or no icon at all?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126792/#review91390
-----------------------------------------------------------


On Jan. 19, 2016, 9:17 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126792/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 9:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 353358
>     http://bugs.kde.org/show_bug.cgi?id=353358
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When showing QIcons in IconItem, it would ignore stylesheet colors.
> This tries to load QIcons created with QIcon::fromTheme as svg, by using the icon name returned from QIcon::name.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.cpp 9129aa1 
> 
> Diff: https://git.reviewboard.kde.org/r/126792/diff/
> 
> 
> Testing
> -------
> 
> Set app icons to breeze light, desktop theme as breeze dark. Icons in desktop toolbox now follows the color scheme.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160121/aecb3db4/attachment.html>