Review Request 126822: AppletQuickItem: Don't try to set initial size bigger than parent size

David Rosca nowrep at gmail.com
Wed Jan 20 14:05:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126822/
-----------------------------------------------------------

Review request for Plasma.


Bugs: 358200
    http://bugs.kde.org/show_bug.cgi?id=358200


Repository: plasma-framework


Description
-------

Trying to set initial size bigger than parent size only results to item being resized down to fit in parent later.

This fixes issue in this case:
Applet sets its initial size with width and height properties, this size makes the applet switch to full representation. This applet is in panel and this initial size doesn't fit in panel. So at first, the applet gets resized to this size, this triggers switch to full representation from compactRepresentationCheck. Applet is then resized to fit in panel, making it to switch to compact representation. The initial size (from width, height properties) is now lost.


Diffs
-----

  src/plasmaquick/appletquickitem.cpp 995ec10 

Diff: https://git.reviewboard.kde.org/r/126822/diff/


Testing
-------

Bug fixed.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160120/ba5a1623/attachment.html>


More information about the Plasma-devel mailing list