Review Request 126807: Ensure connection to exist before using

[Andreas Cord-Landwehr]

> On Jan. 19, 2016, 6:35 nachm., Rajeesh K V wrote:
> > I must admit I don't understand the root cause or how m_connection could be null, but as this fixes the crash - ship it.

If I am not mistaken, the root cause is the following:
* XLibTouchpad has a member variable m_touchpadOffAtom
* this variable is created by the default constructor that sets the connection to 0
* no m_touchpadOffAtom.intern(...) call is performed to set the connection, so it remains 0
The question now for me is, what are the correct parameters for m_touchpadOffAtom.inter(...). On the one hand it should be m_connection, on the other hand I do not know what the parameter "name" should name. The correct position would be IMO plasma-desktop/kcms/touchpad/src/backends/x11/xlibtouchpad.cpp line 266 to make this call.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126807/#review91343
-----------------------------------------------------------


On Jan. 19, 2016, 9:24 vorm., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126807/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 9:24 vorm.)
> 
> 
> Review request for Plasma and Alexander Mezin.
> 
> 
> Bugs: 357907
>     https://bugs.kde.org/show_bug.cgi?id=357907
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is an attempt to fix the crash reported at https://bugs.kde.org/show_bug.cgi?id=357907.
> Yet, I am neither familiar with the code nor with using XCB. So I cannot judge if this is only a workaround or a proper fix.
> 
> 
> Diffs
> -----
> 
>   kcms/touchpad/src/backends/x11/xcbatom.cpp 06f7f52 
> 
> Diff: https://git.reviewboard.kde.org/r/126807/diff/
> 
> 
> Testing
> -------
> 
> Solves the crashes for me.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/566d1052/attachment.html>