Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

[David Rosca]

> On Jan. 19, 2016, 3:07 p.m., David Edmundson wrote:
> > desktoppackage/contents/configuration/AppletConfiguration.qml, line 168
> > <https://git.reviewboard.kde.org/r/126802/diff/1/?file=434493#file434493line168>
> >
> >     don't set width in a child of a Layout
> >     
> >     the layout will be altering this property so this gets overriden. We only want to set the implicitWidth
> >     (also if you set implicitWidth to width in a layout you get an effective binding loop, but one that doesn't print a warning)

Setting just `implicitWidth` doesn't help, I still have the issue from screenshot.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126802/#review91331
-----------------------------------------------------------


On Jan. 19, 2016, 4:12 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126802/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 4:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Fixes issue where the contents rectangle may be smaller than the ScrollView's width.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/AppletConfiguration.qml 0302c7a 
> 
> Diff: https://git.reviewboard.kde.org/r/126802/diff/
> 
> 
> Testing
> -------
> 
> Issue fixed (the issue doesn't occur for every config dialog).
> To be honest, it fixes binding loop on `width` in our code, but also brings binding loop on `value` in Qt ScrollView.qml. But it still fixes the issue.
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/18/4d06a54a-ac6c-45dc-8c32-53415e8b35d5__before.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/a0b210f9/attachment.html>