Review Request 126814: IconItem: Add usePlasmaIcons property

Marco Martin notmart at gmail.com
Tue Jan 19 14:06:28 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126814/#review91330
-----------------------------------------------------------


Ship it!




wouls prefer the property to be called usesPlasmaTheme

- Marco Martin


On Jan. 19, 2016, 1:35 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126814/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 1:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add usePlasmaIcons (enabled by default) property to make it possible to disable using icons from Plasma theme.
> 
> I'm not really sure on the name, this is best I could come up with.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 6486a8c 
>   src/declarativeimports/core/iconitem.cpp 001f65b 
> 
> Diff: https://git.reviewboard.kde.org/r/126814/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/d6dd2e0d/attachment.html>


More information about the Plasma-devel mailing list