Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview

[David Edmundson]

> On Jan. 19, 2016, 8:51 a.m., Marco Martin wrote:
> > sure it's not just hiding it?
> > some times if you do the syncing by javascript it goes undetected and you fin yourself with 100% cpu without knowing why
> 
> David Rosca wrote:
>     That's possible, but I can't see any problems with cpu usage. 
>     
>     The other fix is to use `Layout.preferredWidth: visible ? units.gridUnit * 7 : 0` instead of setting `width` and `implicitWidth`. It also fixes the issue and looks better code-wise, but on runtime it produces 3 binding loop warnings.

you don't need to do the implicitWidth: visible ? something : 0


Layouts will do that automatically.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126802/#review91314
-----------------------------------------------------------


On Jan. 18, 2016, 7:23 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126802/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 7:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Fixes issue where the contents rectangle may be smaller than the ScrollView's width.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/AppletConfiguration.qml 0302c7a 
> 
> Diff: https://git.reviewboard.kde.org/r/126802/diff/
> 
> 
> Testing
> -------
> 
> Issue fixed (the issue doesn't occur for every config dialog).
> To be honest, it fixes binding loop on `width` in our code, but also brings binding loop on `value` in Qt ScrollView.qml. But it still fixes the issue.
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/18/4d06a54a-ac6c-45dc-8c32-53415e8b35d5__before.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/8261b533/attachment.html>