Review Request 125973: Remove completely duplicated function
David Edmundson
david at davidedmundson.co.uk
Tue Jan 19 12:22:21 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125973/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 12:22 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit e67f33a8ec2bc61d470493f7a77f0c80ab9e9499 by David Edmundson to branch master.
Repository: plasma-workspace
Description
-------
Remove almost completely duplicated function.
One was used for right clicking on expanded items, the other for full compact items.
A missing action for expanded items is added so the two menus are now consistent.
Global co-ordinates are used as args for menus everywhere so we can share the mapping code SNIs currently use.
Diffs
-----
applets/systemtray/package/contents/ui/ExpandedRepresentation.qml a53be6cb0d9fae14e055a6d1381ad11fee0a236e
applets/systemtray/package/contents/ui/PlasmoidItem.qml c4f8ccb994ab605121de05ef6a966d2a565f171b
applets/systemtray/plugin/host.h db6fc567666281c8b2fe81eab085ae4b950bf07d
applets/systemtray/plugin/host.cpp 61e87050826a28409e44c8dac5baebe12e59bf63
applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 84d2baf4da0ef6d0381dfc79fa374b5c54cf2189
Diff: https://git.reviewboard.kde.org/r/125973/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/7f0914ad/attachment.html>
More information about the Plasma-devel
mailing list