Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

David Rosca nowrep at gmail.com
Tue Jan 19 09:17:54 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126792/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 10:17 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 5184ac94c916bf5e5e31d60db841c88009758a62 by David Rosca to branch master.


Bugs: 353358
    http://bugs.kde.org/show_bug.cgi?id=353358


Repository: plasma-framework


Description
-------

When showing QIcons in IconItem, it would ignore stylesheet colors.
This tries to load QIcons created with QIcon::fromTheme as svg, by using the icon name returned from QIcon::name.


Diffs
-----

  src/declarativeimports/core/iconitem.cpp 9129aa1 

Diff: https://git.reviewboard.kde.org/r/126792/diff/


Testing
-------

Set app icons to breeze light, desktop theme as breeze dark. Icons in desktop toolbox now follows the color scheme.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/ec11b15f/attachment.html>


More information about the Plasma-devel mailing list