Review Request 126800: AppletConfiguration: Use QIconItem for category icons
Marco Martin
notmart at gmail.com
Tue Jan 19 08:52:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126800/#review91315
-----------------------------------------------------------
Ship it!
I'm fine with the change, but... wasn't iconitem supposed to get a property for not using the svg?
- Marco Martin
On Jan. 18, 2016, 6:47 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126800/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 6:47 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> PlasmaCore.IconItem uses plasma color scheme, which is not what we want in applet config.
>
>
> Diffs
> -----
>
> desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fc87c6f
>
> Diff: https://git.reviewboard.kde.org/r/126800/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/7eb5a252/attachment.html>
More information about the Plasma-devel
mailing list