Review Request 126647: [Task Manager] Provide media controls in tooltips

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126647/#review91207
-----------------------------------------------------------


Ship it!




Ship It!

- Eike Hein


On Jan. 7, 2016, 9:05 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126647/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 9:05 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 352126
>     https://bugs.kde.org/show_bug.cgi?id=352126
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This adds media player controls to the tooltip of a media player, using the already existing mpris dataengine this was pretty straightforward to implement.
> 
> When album art is available, no window thumbnails will be shown, instead the album art. There will be a close button on the album art closing the first window. Multiple windows for a player is uncommon and you can still access them all by clicking the task manager entry.
> 
> Interestingly enough, Amarok does not expose its album art through MPris. Also, if it wouldn't crash whilst doing so, you could control Amarok when it's main window is closed if you have a launcher pinned to your task manager, basically rendering its tray icon obsolete.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/Task.qml 2a88886 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 4bf0b31 
> 
> Diff: https://git.reviewboard.kde.org/r/126647/diff/
> 
> 
> Testing
> -------
> 
> Works with VLC and Audacious, does not work with Dragon as the player announces itself as "dragonplayer" while its Desktop file says "dragon"
> 
> 
> File Attachments
> ----------------
> 
> VLC with album art
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/3058dacb-1dfd-464d-a1ec-be90bc9e58a8__mpristaskmanagerreview1.png
> Amarok without album art
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/6799d6f6-d505-4f56-9531-3013a3e34ae6__mpristaskmanagerreview2.png
> No gradient
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/06/25298761-28bb-4620-b768-dd0259f19b82__mpristaskmanagerreview3.png
> Raising Amarok through its launcher
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/8dfcb9b6-6e11-4017-b4fc-70d92c9ded2a__mpristaskmanagerreview4.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160117/3d1c1eeb/attachment.html>