Review Request 126713: fix font preview colors

[Thomas Lübking]

> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote:
> > Can I suggest you copy SNIProxy::convertFromNative from plasma-workspace/xembedsniproxy/sniproxy.cpp
> > 
> > (which in itself is copied from KWindowSystem, which I think was copied from Qt....)
> 
> David Edmundson wrote:
>     ...or maybe I should be the one copying this.  I have a completely lying comment about Format_RGB30 not existing.
> 
> Thomas Lübking wrote:
>     The 30 and some 32 bit formats are more recent additions to Qt5 (5.4, iirc)
>     
>     I think I even suggested to have kxutils somewhere public - seems it's becoming more demanding ;-)
>     
>     (We'd proabably need to port the DefaultVisual stuff there, I simply used what's already used in FcEngine)
>     
>     Martin?

So, what do we do
Push this into 5.5 and seek for a public kxutils to rely on in the next frameworks release?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126713/#review90858
-----------------------------------------------------------


On Jan. 10, 2016, 10:48 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126713/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 10:48 p.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Martin Klapetek.
> 
> 
> Bugs: 336089
>     https://bugs.kde.org/show_bug.cgi?id=336089
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> the image format was hardcoded to ARGB32_Premultiplied, but that's not generally correct, notably not on 24bit servers
> 
> 
> Diffs
> -----
> 
>   kcms/kfontinst/lib/FcEngine.cpp 19b7206 
> 
> Diff: https://git.reviewboard.kde.org/r/126713/diff/
> 
> 
> Testing
> -------
> 
> yes, bug.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160115/36b6e7b7/attachment.html>