Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91150
-----------------------------------------------------------


Ship it!




Looks good to me, maybe just change what I pointed out (storing just UUIDs as strings instead active connections). I don't have time right now to test it, but I trust you that it works.

Looking only for active connections would probably require increasing the time at least to 10 seconds, just leave it as it is for now.

- Jan Grulich


On Led. 15, 2016, 3:03 odp., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> -----------------------------------------------------------
> 
> (Updated Led. 15, 2016, 3:03 odp.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> It's quite natural that the connection goes away when we're about to suspend :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -----
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> -------
> 
> While I still think Plasma-NM is waaaaaay too verbose about everything, at least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160115/1b8661aa/attachment.html>