Review Request 126751: Expose BCP47 language id in shell scripting interface

Marco Martin notmart at gmail.com
Fri Jan 15 13:04:56 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126751/#review91141
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Jan. 15, 2016, 2:10 a.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126751/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 2:10 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The existing 'language' property yields a human-readable string like "English". For scripting purposes it's more useful to operate on a BCP47 language id (e.g. 'en') since it makes for shorter strings, and language lists in other parts of the system tend to use them, making comparisons and keeping things in sync easier.
> 
> 
> Diffs
> -----
> 
>   shell/scripting/appinterface.h 93aa014 
>   shell/scripting/appinterface.cpp 2c54f1e 
> 
> Diff: https://git.reviewboard.kde.org/r/126751/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160115/b300b64c/attachment.html>


More information about the Plasma-devel mailing list