Review Request 126749: change exec mimetype color from green to red
Gregor Mi
codestruct at posteo.org
Thu Jan 14 22:34:03 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126749/#review91117
-----------------------------------------------------------
I would like to note that Uri's comment here https://forum.kde.org/viewtopic.php?f=285&t=128846#p343970 implies that green is (or should be?) the color for executable files.
Though personally, I find red a good choice because there are far less executable files around than normal ones and executable files are potentially harmful.
- Gregor Mi
On Jan. 14, 2016, 10:24 p.m., andreas kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126749/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 10:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: breeze-icons
>
>
> Description
> -------
>
> https://forum.kde.org/viewtopic.php?f=285&t=130558
>
>
> Diffs
> -----
>
> icons-dark/mimetypes/16/application-x-executable-script.svg 3b80b05
> icons-dark/mimetypes/16/application-x-executable.svg 03d554c
> icons-dark/mimetypes/22/application-x-executable-script.svg c267213
> icons-dark/mimetypes/22/application-x-executable.svg b8e1a8c
> icons-dark/mimetypes/32/application-x-executable-script.svg ba195a5
> icons-dark/mimetypes/32/application-x-executable.svg 6a7baa1
> icons-dark/mimetypes/64/application-x-executable-script.svg ce07afd
> icons-dark/mimetypes/64/application-x-executable.svg da866d6
> icons/mimetypes/16/application-x-executable-script.svg 3b80b05
> icons/mimetypes/16/application-x-executable.svg 03d554c
> icons/mimetypes/22/application-x-executable-script.svg c267213
> icons/mimetypes/22/application-x-executable.svg b8e1a8c
> icons/mimetypes/32/application-x-executable-script.svg ba195a5
> icons/mimetypes/32/application-x-executable.svg 6a7baa1
> icons/mimetypes/64/application-x-executable-script.svg ce07afd
> icons/mimetypes/64/application-x-executable.svg da866d6
>
> Diff: https://git.reviewboard.kde.org/r/126749/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> left old right new
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/14/634c3a94-4ea9-4025-ba88-d63d6196efbb__exec.png
>
>
> Thanks,
>
> andreas kainz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160114/2c99ce6d/attachment.html>
More information about the Plasma-devel
mailing list