Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Martin Klapetek]

> On Jan. 14, 2016, 7:22 p.m., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
>     Doesn't it tell you that anyway? At least when I try to connect to something and it fails I get like 3 notifications about different failures.

What I mean is when you suspend your laptop at home, connected to your home network, you go out and resume your laptop say at your friend where you didn't connect to the wifi before, so it's unknown and your laptop will not connect to anything and will not even try. At that point, it should show a "disconnected" notification, maybe?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
-----------------------------------------------------------


On Jan. 14, 2016, 7:19 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 7:19 p.m.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> It's quite natural that the connection goes away when we're about to suspend :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -----
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> -------
> 
> While I still think Plasma-NM is waaaaaay too verbose about everything, at least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160114/ddf25ba7/attachment.html>