Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending
Martin Klapetek
martin.klapetek at gmail.com
Thu Jan 14 18:22:05 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
-----------------------------------------------------------
It should probably still show when you get disconnected and *not* reconnected (to any network) on resume?
- Martin Klapetek
On Jan. 14, 2016, 7:19 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 7:19 p.m.)
>
>
> Review request for Plasma and Jan Grulich.
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> It's quite natural that the connection goes away when we're about to suspend :) Watch for this and then don't emit the notification.
>
>
> Diffs
> -----
>
> kded/notification.h 9b8b51a
> kded/notification.cpp 231d69e
>
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
>
>
> Testing
> -------
>
> While I still think Plasma-NM is waaaaaay too verbose about everything, at least it doesn't tell me that I just disconnected when I suspend.
>
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after resuming.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160114/7fb32ba2/attachment.html>
More information about the Plasma-devel
mailing list