Review Request 126668: [notifications] Place the popup directly when it is displayed

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126668/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 7:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit c1a7d61fbab7620f9f92f25ae82e96b9bf3a589c by Martin Klapetek to branch Plasma/5.5.


Repository: plasma-workspace


Description
-------

Now with the geometry being correct right after the popup is
being displayed, it can be placed directly to its exact intended
position (compared to sliding from default position because the
geometry was not known).

This should fix any issues left with the popups flying across
the screen and removes tons of code as a bonus.

Can somebody please please test this patch this time. I have been
running it whole day testing all scenairos I could think of but
there is always at least one I miss. So please try this.


Diffs
-----

  applets/notifications/plugin/notificationshelper.h d5c15cc 
  applets/notifications/plugin/notificationshelper.cpp dbc30d6 

Diff: https://git.reviewboard.kde.org/r/126668/diff/


Testing
-------

Everything works as it should, plus I think the first placement
of the popup is now way nicer.

PLEASE SOMEBODY SACRIFICE 2 MINUTES TO APPLY THIS PATCH AND TRY IT


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160113/81e791be/attachment.html>