Review Request 126732: a plymouth theme for breeze

[Sebastian Kügler]

> On Jan. 13, 2016, 2:36 p.m., Sebastian Kügler wrote:
> > plymouth/CMakeLists.txt, line 1
> > <https://git.reviewboard.kde.org/r/126732/diff/1/?file=430526#file430526line1>
> >
> >     What about systems without plymouth?
> >     
> >     I'm not sure if it's a good idea to make this a mandatory dependency.
> 
> Jonathan Riddell wrote:
>     then it won't get installed
>     it's not mandatory, it's optional on plymouth being installed

Ah right, I see it now. Sorry for being dense.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126732/#review91006
-----------------------------------------------------------


On Jan. 13, 2016, 2:27 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126732/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 2:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> a plymouth theme for breeze
> 
> based on kubuntu theme, it's one image with a fading in and out glow
> also a 16 bit fallback which is just the static k logo
> some cmake to look for the current plymouth theme diretory which could do with testing on other distros
> it doesn't try to set it as default theme or run update-initramfs, I think that can only be done by packagers
> suggestions for artwork welcome but changing the functionality (fade in and out glow) is not something I have the knowledge or time for
> I've not included a text fallback theme, the plymouth text theme seems very limited in functionality and the ubuntu-text theme is presumably distro specific
> 
> http://weegie.edinburghlinux.co.uk/~jr/tmp/out-3.ogv
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cdcc46e 
>   cmake/FindPlymouth.cmake PRE-CREATION 
>   plymouth/CMakeLists.txt PRE-CREATION 
>   plymouth/breeze/README PRE-CREATION 
>   plymouth/breeze/breeze.grub PRE-CREATION 
>   plymouth/breeze/breeze.plymouth.in PRE-CREATION 
>   plymouth/breeze/breeze.script PRE-CREATION 
>   plymouth/breeze/images/16bit/dot.png PRE-CREATION 
>   plymouth/breeze/images/16bit/logo.png PRE-CREATION 
>   plymouth/breeze/images/16bit/progress-rect.png PRE-CREATION 
>   plymouth/breeze/images/16bit/text-input.png PRE-CREATION 
>   plymouth/breeze/images/dot.png PRE-CREATION 
>   plymouth/breeze/images/logo-glow.png PRE-CREATION 
>   plymouth/breeze/images/logo.png PRE-CREATION 
>   plymouth/breeze/images/source.svgz PRE-CREATION 
>   plymouth/breeze/images/text-input.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126732/diff/
> 
> 
> Testing
> -------
> 
> installed this
> set default.plymouth link to point to breeze.plymouth
> install plymouth-x11
> sudo plymouthd --debug --tty=`tty` --no-daemon
> sudo plymouth show-splash
> pretty K blinks
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160113/02f0f902/attachment.html>