Review Request 126632: add a "Complementary" color scheme to kcolorscheme

Sebastian Kügler sebas at kde.org
Mon Jan 11 11:41:41 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126632/#review90879
-----------------------------------------------------------


+1 from me, too.

- Sebastian Kügler


On Jan. 5, 2016, 11:16 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126632/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:16 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> Since some releases, plasma-frameworks locally expands kcolorscheme to have a new "Complementary" section: this is done for things like the lockscreen and the logout ui, where the colors are flipped from the current theme.
> A local extension there is kinda unfortunate as makes the color configs files not completely compatible, and I think there is an use case for this in normal applications as well (Gwenview switches to a dark palette when in fullscreen mode for instance)
> Since I want to make the default plasma theme follow the system color scheme, I would need for it to support this "complementary" area as well.
> 
> 
> Diffs
> -----
> 
>   src/kcolorscheme.h 22bc21b 
>   src/kcolorscheme.cpp 427ffa4 
> 
> Diff: https://git.reviewboard.kde.org/r/126632/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160111/5bc7b797/attachment.html>


More information about the Plasma-devel mailing list