Review Request 126688: RFC: [Device Notifier] Provide inline feedback

[Kai Uwe Broulik]

> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote:
> > Very nice!
> > 
> > Gut feeling feedback:
> > 
> > - the error message's icon could take the place of the eject icon
> > - the "safely remove" icon could go away, text made italic (not sure if there's prior art in the HIG, I'm just imagining it would look less invasive)
> 
> Kai Uwe Broulik wrote:
>     Please no italic text. Another idea would be having an emblem on the device icon, we indicate mounted vs not mounted, so we could show error / success there as well/instead.
> 
> Thomas Pfeiffer wrote:
>     Using an emblem sounds reasonable, though we would have to test whether it's recognizeable at a glance.
> 
> andreas kainz wrote:
>     please make the status icons smaller than the device icons.
> 
> Kai Uwe Broulik wrote:
>     Btw I need proper icons for the success and error case.
>     dialog-information provides a black and white 22/24 size icon which doesn't work when used as overlay
>     dialog-error looks okay'ish but also is clearly not meant to be used as badge.
>     
>     The icon for vcs-conflicting and vcs-normal would work but I need them with a proper name, of course, or something like task-complete and task-reject as provided by Oxygen.
> 
> andreas kainz wrote:
>     icon Name and size please
> 
> andreas kainz wrote:
>     like the new overlay icons only emblem icons can be used as overlay icon so say me the name and I will add Themen to the emblem folder. all other icons are not useful for overlay.
> 
> Kai Uwe Broulik wrote:
>     Icon name: I guess emblem-error and emblem-success (these don't exist in the FDO spec)
>     Icon size: no idea, I guess an 8x8 variant and 16x16?
> 
> andreas kainz wrote:
>     8x8 should be enough I added some new emblem icons
>     https://share.kde.org/index.php/s/z1LkxYIOD6dXelP

Nice! Those should work nicely, warning is spelled with an A, however :)


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review90819
-----------------------------------------------------------


On Jan. 10, 2016, 8:44 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 8:44 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Instead of showing a detached status bar with the device name, show the message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely remove this device" message will show up; after 5 seconds the message and the device will disappear. When trying to unmount a device and it fails, device notifier will show up with an error message that will stay there until device notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications engine's wording (I'm open to better verbalizations) and one for the device notifier
> 
> 
> Diffs
> -----
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> -------
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section thing gets confused when the one item is already gone in the model (looks like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device there
> - it cannot actually highlight the device that was safely removed (it's no longer part of the model and thus has no index), we could do a hack for this though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon but the error thing is always red, there's a smaller variant for the former but not the latter apparently, also it seems we lack a proper "task done" icon, Oxygen had one
> 
> 
> File Attachments
> ----------------
> 
> Failed to mount
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> Emblem icon
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160111/46088dca/attachment.html>