Review Request 126687: [DataModel] Don't reset model when source is removed

Mark Gaiser markg85 at gmail.com
Mon Jan 11 09:18:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126687/#review90868
-----------------------------------------------------------


+1

- Mark Gaiser


On jan 10, 2016, 10:03 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126687/
> -----------------------------------------------------------
> 
> (Updated jan 10, 2016, 10:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This allows me to track removing items from a list
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/datamodel.cpp 4449f30 
> 
> Diff: https://git.reviewboard.kde.org/r/126687/diff/
> 
> 
> Testing
> -------
> 
> I now get ListView.onRemove in device notifier. Tests still pass. I have no idea if this approach is correct, however.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160111/cb7ffda4/attachment.html>


More information about the Plasma-devel mailing list