Review Request 126689: Change minimum Size of Calendar

[Martin Klapetek]

> On Jan. 10, 2016, 11:10 p.m., Martin Klapetek wrote:
> > This actually doesn't do anything because the parent item has
> > 
> > Plasmoid.switchWidth: units.gridUnit * 12
> > Plasmoid.switchHeight: units.gridUnit * 12
> > 
> > ...so it would never get the full representation to *3.
> > 
> > Plus, the calendar looks really broken at the minimum size
> > (when the switch size is removed), so *3 makes no sense.
> > 
> > http://paste.opensuse.org/view/raw/72636384

(btw gridUnit is defined as height of "M", the full representation
of the calendar cannot be fitted into "3 times the height of M",
so in fact, I think this should be reverted as is)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126689/#review90855
-----------------------------------------------------------


On Jan. 10, 2016, 8:56 p.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126689/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 8:56 p.m.)
> 
> 
> Review request for Plasma and Heiko Tietze.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> it's the minimum usefull size for the calendar applet on the desktop
> 
> https://git.reviewboard.kde.org/r/126356/
> 
> 
> Diffs
> -----
> 
>   applets/calendar/contents/ui/main.qml 863a6f3 
> 
> Diff: https://git.reviewboard.kde.org/r/126689/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> calendar min
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/94ccc241-fc5d-4987-afd4-9139ab0d45d7__calendarMinimumSize.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160110/eb56cd36/attachment.html>