Review Request 126687: [DataModel] Don't reset model when source is removed

David Edmundson david at davidedmundson.co.uk
Sun Jan 10 21:00:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126687/#review90848
-----------------------------------------------------------



src/declarativeimports/core/datamodel.cpp (line 466)
<https://git.reviewboard.kde.org/r/126687/#comment62076>

    we want this part unconditionally.


- David Edmundson


On Jan. 10, 2016, 8:59 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126687/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 8:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This allows me to track removing items from a list
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/datamodel.cpp 4449f30 
> 
> Diff: https://git.reviewboard.kde.org/r/126687/diff/
> 
> 
> Testing
> -------
> 
> I now get ListView.onRemove in device notifier. Tests still pass. I have no idea if this approach is correct, however.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160110/fa0a9f4e/attachment-0001.html>


More information about the Plasma-devel mailing list