Review Request 126687: [DataModel] Don't reset model when source is removed

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126687/#review90843
-----------------------------------------------------------



src/declarativeimports/core/datamodel.cpp (line 463)
<https://git.reviewboard.kde.org/r/126687/#comment62074>

    what if m_items.value(sourceName).count() is 0 ?


- David Edmundson


On Jan. 10, 2016, 5:10 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126687/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 5:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This allows me to track removing items from a list
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/datamodel.cpp 4449f30 
> 
> Diff: https://git.reviewboard.kde.org/r/126687/diff/
> 
> 
> Testing
> -------
> 
> I now get ListView.onRemove in device notifier. Tests still pass. If I change the filter in Device Notifier (eg. show all or show non-removable) it doesn't update the model live. I have no idea if this approach is correct, however.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160110/b44bd359/attachment.html>