Review Request 126658: Notifications again not works correctly [revert parch 126408]

Anthony Fieroni bvbfan at abv.bg
Sat Jan 9 12:52:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126658/
-----------------------------------------------------------

(Updated Ян. 9, 2016, 2:52 след обяд)


Review request for Plasma, David Edmundson, Marco Martin, and Martin Klapetek.


Repository: plasma-workspace


Description
-------

Review 126408 completely same flying and configurations issues


Diffs
-----

  applets/notifications/plugin/notificationshelper.cpp 15b4479 
  applets/notifications/package/contents/ui/configNotifications.qml 95a8e59 
  applets/notifications/package/contents/ui/Notifications.qml f479a65 
  applets/notifications/lib/notificationsapplet.h 5b262f1 
  applets/notifications/lib/notificationsapplet.cpp 891cdb0 
  applets/notifications/plugin/notificationshelper.h 860a2da 
  applets/notifications/package/contents/ui/ScreenPositionSelector.qml efff648 

Diff: https://git.reviewboard.kde.org/r/126658/diff/


Testing
-------

My code works *correctly*, revert patch from 126408 - configurations issues.
Qt 5.5.1, libxcb 1.11.1 Arch Linux


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160109/ea41b739/attachment.html>


More information about the Plasma-devel mailing list