Review Request 126669: [Task Manager] Don't show on which virtual desktop a window is if there is just one

Eike Hein hein at kde.org
Fri Jan 8 03:21:01 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126669/#review90786
-----------------------------------------------------------

Ship it!


Ship It!

- Eike Hein


On Jan. 7, 2016, 10 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126669/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 10 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> There's no point.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/Task.qml 2a88886 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 4bf0b31 
>   applets/taskmanager/plugin/backend.h 3879d94 
>   applets/taskmanager/plugin/backend.cpp f83ae09 
> 
> Diff: https://git.reviewboard.kde.org/r/126669/diff/
> 
> 
> Testing
> -------
> 
> With one virtual desktop -> it doesn't say anything
> With more than one virtual desktop -> says on which virtual desktop a window is on
> 
> The text regarding on which activity a window is on is unchanged, as it doesn't show up if a window is only associated with the current activity anyway
> 
> 
> File Attachments
> ----------------
> 
> No virtual desktop mentioned
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/e343ed65-c29d-4fdc-bb51-adc9b9e29138__tooltipnovirtualdesktop.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160108/8b0f2f82/attachment.html>


More information about the Plasma-devel mailing list