Review Request 126300: Plasma Search KCM: display the runner descriptions

[Jonathan Marten]

> On Jan. 7, 2016, 10:42 a.m., Heiko Tietze wrote:
> > Looks good from the usability POV. But what happens with very long text, like Finnish translation? In the HIG we wrote "Do not add line breaks. If necessary place an additional label below the check box." (which is worth to revise). But with a line wrap the layout of the checkbox list is destroyed due to the different column height. Either we accept this or you cut with ellipsis the overlong labels forcing the l10n to shorten the text (my preference).

Long lines are truncated, although the full text will show if the window is resized wide enough - see "Control Audio Player" in the 3rd screenshot above.  So the layout is not destroyed by long lines.  Is this acceptable, or should there be an ellipsis?


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/#review90742
-----------------------------------------------------------


On Jan. 7, 2016, 1:50 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126300/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 1:50 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> In Plasma 5 this KCM only lists the names of the available runners, with no explanation of what they do.  In its previous incarnation in KDE4 (the dropdown list from the runner config button), the descriptions were displayed.  This change restores them.
> 
> 
> Diffs
> -----
> 
>   kcms/runners/kcm.h f1239ee 
>   kcms/runners/kcm.cpp 4af82de 
> 
> Diff: https://git.reviewboard.kde.org/r/126300/diff/
> 
> 
> Testing
> -------
> 
> Built plasma-desktop with this change, checked appearance of KCM in Breeze, Oxygen and older styles.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
> Screenshot after
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
> Long lines truncated
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/f91d5bc6-eb02-49e1-b99a-337ee6823fec__plasmasearch-longlines-r126300.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160107/39284bef/attachment.html>