Review Request 126654: rework ColorScope, hopefully fix black on black battery on phone

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126654/#review90734
-----------------------------------------------------------

Ship it!


Ship It!

- Bhushan Shah


On Jan. 6, 2016, 11:45 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126654/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 11:45 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Since some time PlasmaCore had the very useful ColorScope class,
> which can semi-automatically make children take colors of the
> View, Button or Complementary color groups.
> Unfortunately it didn't support dynamic reparenting, giving
> wrong colors in some cases (see black on black battery on the phone)
> 
> even tough is a bit complicated, now by cascading signals down the
> children tree, support on the fly apply of the new context upon
> reparenting.
> 
> also add a manual test case showing text, rectangles and icons
> dynamically changing color as they get moved from one scope
> to the other
> 
> 
> Diffs
> -----
> 
>   tests/colorcontext.qml PRE-CREATION 
>   src/declarativeimports/core/colorscope.cpp 92dcb3e 
>   src/declarativeimports/core/colorscope.h 93b3303 
> 
> Diff: https://git.reviewboard.kde.org/r/126654/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> context1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/06/0f1bf140-9ac3-4ca8-9f42-c6d51c1dad3c__context1.png
> context2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/06/a65435ce-bec6-4272-b353-5c5d4a4178fb__context2.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160107/4504d901/attachment.html>