Review Request 126652: [Units] Return at least 1ms for durations
Kai Uwe Broulik
kde at privat.broulik.de
Wed Jan 6 12:39:52 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126652/
-----------------------------------------------------------
Review request for Plasma.
Bugs: 357352
http://bugs.kde.org/show_bug.cgi?id=357352
Repository: plasma-framework
Description
-------
Animators do not reliably fire with a duration of 0 as can be seen in the linked bug report.
Upstream bug report: https://bugreports.qt.io/browse/QTBUG-39766
Diffs
-----
src/declarativeimports/core/units.cpp 1798727
src/declarativeimports/plasmacomponents/qml/PageStack.qml cdb2a49
Diff: https://git.reviewboard.kde.org/r/126652/diff/
Testing
-------
This fixes Widget Explorer and System Tray for me.
Yet another reason not to divide long/shortDuration by arbitrary values. :)
Also I don't know if there are things that check for an animation duration to disable certain behaviors.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160106/05e8a278/attachment.html>
More information about the Plasma-devel
mailing list