Review Request 126637: IconItem: Add animated property

[Marco Martin]

> On Jan. 6, 2016, 12:14 p.m., Kai Uwe Broulik wrote:
> > I'm not arguing against the addition of this property, my patch should significantly reduce the need for it and prevent abusing it, however.
> > 
> > Most cases where you don't want to fade the pixmap is when the view it's in was previously hidden, like a tooltip or the OSD because when it shows up again the context will be vastly different and a fade animation just confusing. However, when the view is still there, a fade animation might still be desired, and then you need to do ugly tricks to get the "animated" property do what you want: eg, animated: !foo.Window.visibility === Window.Visible or something like that

is your patch already in?
can we have it running and tested for a while before deciding if this one is needed as well?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126637/#review90692
-----------------------------------------------------------


On Jan. 6, 2016, 11 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126637/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 11 a.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add property animated, that allows to disable cross-fade animation when changing icon (enabled by default).
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 366edf3 
>   src/declarativeimports/core/iconitem.cpp db15d0f 
> 
> Diff: https://git.reviewboard.kde.org/r/126637/diff/
> 
> 
> Testing
> -------
> 
> Setting `animated: false` disables the animation.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160106/e6d61d5e/attachment.html>