Review Request 126636: TaskManager: Enable vertical scroll in tooltip

[Marco Martin]

> On Jan. 5, 2016, 2:02 p.m., David Edmundson wrote:
> > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml, line 62
> > <https://git.reviewboard.kde.org/r/126636/diff/1/?file=428519#file428519line62>
> >
> >     I'm a bit confused.
> >     
> >     We explicitly disable interactive (scrolling) on the scrollArea
> >     
> >     then we put a mouse area on top which forwards scroll events to the scroll area.
> 
> David Rosca wrote:
>     This translates vertical scroll to horizontal. It only actually scrolls when the ScrollArea is interactive = when all windows don't fit in tooltip.
> 
> Marco Martin wrote:
>     if a flickable has only horizontal scrolling enabled, iirc the mouse wheel will scroll horizontally?
> 
> David Rosca wrote:
>     It doesn't, at least not for me (Qt 5.6).
> 
> Kai Uwe Broulik wrote:
>     > if a flickable has only horizontal scrolling enabled, iirc the mouse wheel will scroll horizontally?
>     
>     Unfortunately not, this is also an issue in the Lock Screen, reported here https://bugreports.qt.io/browse/QTBUG-47579

so meh, we'll have to go with this approach


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126636/#review90648
-----------------------------------------------------------


On Jan. 5, 2016, 12:52 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126636/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 12:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Enable vertical scroll for windows ScrollArea.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 972dd62 
> 
> Diff: https://git.reviewboard.kde.org/r/126636/diff/
> 
> 
> Testing
> -------
> 
> Scrolling works
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160106/7763e2e8/attachment-0001.html>