Review Request 126647: [Task Manager] Provide media controls in tooltips

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126647/#review90674
-----------------------------------------------------------


I agree with the album art suggestion - or we could build on your composition approach and superimpose the album art on top with a soft shadow halo around, maybe.


applets/taskmanager/package/contents/ui/Task.qml (line 192)
<https://git.reviewboard.kde.org/r/126647/#comment61973>

    Semicolae;



applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (line 209)
<https://git.reviewboard.kde.org/r/126647/#comment61974>

    Wondering how this compares to GraphicalEffects' LinearGradient



applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (line 211)
<https://git.reviewboard.kde.org/r/126647/#comment61976>

    I think a little bit higher in the buttons would look nicer



applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (line 243)
<https://git.reviewboard.kde.org/r/126647/#comment61975>

    Was wondering if this should be an icon size + margins, then again choosing numbers proportional to the thumbnail rect size might make more sense


- Eike Hein


On Jan. 5, 2016, 8:45 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126647/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 8:45 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 352126
>     https://bugs.kde.org/show_bug.cgi?id=352126
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This adds media player controls to the tooltip of a media player, using the already existing mpris dataengine this was pretty straightforward to implement.
> 
> In order not to change the tooltip dialog size, the controls are placed ontop of the thumbnail with a little fade effect at the bottom to improve contrast.
> 
> There could be multiple grouped windows of a given player, unlikely though, but it doesn't look too bad with that either.
> 
> The app in the screenshot is just for demo purposes, the buttons are disabled in the screenshot, they're a darker black usually.
> The button reflects play/pause state, forward/back are disabled if not possible and the controls, obviously, are only shown for tasks with an associated mpris interface.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/Task.qml 2a88886 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 972dd62 
> 
> Diff: https://git.reviewboard.kde.org/r/126647/diff/
> 
> 
> Testing
> -------
> 
> Works with VLC and Audacious, does not work with Dragon as the player announces itself as "dragonplayer" while its Desktop file says "dragon"
> 
> 
> File Attachments
> ----------------
> 
> Tooltip with media controls
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/79c94b3c-5d64-4eb2-8cc6-1541abf28e5f__mpristaskfade.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160105/b99a01f2/attachment-0001.html>