Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

David Edmundson david at davidedmundson.co.uk
Tue Jan 5 18:26:00 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126642/#review90664
-----------------------------------------------------------


I don't really understand the problem this is solving.
This wont' solve the problem of downstreams doing their own themes and failing to update their version numbers properly unless they always release at the same time as plasma-framework.

- David Edmundson


On Jan. 5, 2016, 6:11 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126642/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 6:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> We have the version number of the theme and some mtime heuristic yet still we often end up with a broken theme after upgrades when it is changed, when downstreams forget to adjust the version in their theme and so on.
> 
> (I just noticed I never delete the old theme caches...)
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/theme_p.cpp 18419bb 
> 
> Diff: https://git.reviewboard.kde.org/r/126642/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160105/b8096630/attachment.html>


More information about the Plasma-devel mailing list