Review Request 124047: Improve clock's tooltip layout
Martin Klapetek
martin.klapetek at gmail.com
Mon Jan 4 18:03:42 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 6:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit f5297033c4a0fba416b971f2bdbcb04c56858947 by Martin Klapetek to branch master.
Bugs: 348078
https://bugs.kde.org/show_bug.cgi?id=348078
Repository: plasma-workspace
Description
-------
In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now it's a bit of a mess so this brings back the table.
Also simplifies the timeForZone function which is used only for the tooltip.
Diffs
-----
applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9
applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION
applets/digital-clock/package/contents/ui/main.qml e754925
applets/digital-clock/plugin/timezonedata.h 682b7c7
applets/digital-clock/plugin/timezonemodel.h 39f64f4
applets/digital-clock/plugin/timezonemodel.cpp 2fe7b16
Diff: https://git.reviewboard.kde.org/r/124047/diff/
Testing
-------
See screenshots.
File Attachments
----------------
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160104/69af75f2/attachment.html>
More information about the Plasma-devel
mailing list