Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

Martin Klapetek martin.klapetek at gmail.com
Mon Jan 4 16:38:57 UTC 2016



> On Dec. 21, 2015, 11:28 p.m., Kai Uwe Broulik wrote:
> > desktoppackage/contents/applet/CompactApplet.qml, line 37
> > <https://git.reviewboard.kde.org/r/126464/diff/1/?file=425191#file425191line37>
> >
> >     Doesn't it complain about "Cannot assign [undefined] to something"? If not, awesome.

It did, so I changed it to null, now it doesn't ^_^


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/#review89866
-----------------------------------------------------------


On Dec. 21, 2015, 11:12 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126464/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 11:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/
> 
> This actaully sets the tooltip item to the main ToolTipArea.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/applet/CompactApplet.qml f9c29a5 
> 
> Diff: https://git.reviewboard.kde.org/r/126464/diff/
> 
> 
> Testing
> -------
> 
> All works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160104/e5b1ee4a/attachment.html>


More information about the Plasma-devel mailing list