Review Request 126548: Kill PowerDevil runner

[Martin Gräßlin]

> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote:
> > I can see that it provides suspend, sleep, hibernate feature which is still useful (Though for some reason I can't trigger it here). Maybe merge that part into sessions runner and drop others?
> 
> Aleix Pol Gonzalez wrote:
>     I often suspend from KRunner.
> 
> Kai Uwe Broulik wrote:
>     What's wrong about:
>     * Using Kickoff
>     * Using the Lock Logout applet
>     * Pressing a shortcut on your keyboard
>     * Closing the lid
>     * Pressing the power button if configured to suspend
> 
> Kai Uwe Broulik wrote:
>     Crap, that should have become a list.
> 
> Aleix Pol Gonzalez wrote:
>     Maybe I could fit one of those solutions, I just don't see why it needs to be removed.
>     
>     I mostly use KRunner when I have 2 monitors, so closing the lid would just leave it to the other monitor. I don't think I have such a shortcut and I removed kickoff longtime ago because I only used it to suspend my system :D.
> 
> Kai Uwe Broulik wrote:
>     :D Fair enough.
>     
>     I'll clean it up, though, remove all the brightness and profile cruft.

just for the record: most of the times I suspend my system by opening krunner and entering suspend. So https://xkcd.com/1172/ applies


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
-----------------------------------------------------------


On Dec. 28, 2015, 7:28 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 7:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
> 
> 
> Diffs
> -----
> 
>   runners/CMakeLists.txt 48cc379 
>   runners/powerdevil/CMakeLists.txt 7c03e29 
>   runners/powerdevil/Messages.sh 99ae5dc 
>   runners/powerdevil/PowerDevilRunner.h 7995621 
>   runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
>   runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 
> 
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160104/542f8970/attachment-0001.html>