Review Request 126590: [WebBrowser plasmoid] Remember last visited url and restore it on startup.

Kai Uwe Broulik kde at privat.broulik.de
Fri Jan 1 17:39:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126590/#review90408
-----------------------------------------------------------

Ship it!



applets/webbrowser/contents/ui/main.qml (line 40)
<https://git.reviewboard.kde.org/r/126590/#comment61844>

    You also don't need this id anymore now
    
    (Btw, Fix it, then Ship it means that you can fix the issue locally and then just Ship without updating the review request again :)


- Kai Uwe Broulik


On Jan. 1, 2016, 5:34 nachm., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126590/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2016, 5:34 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 357387
>     http://bugs.kde.org/show_bug.cgi?id=357387
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Remember last visited url and restore it on startup.
> BUG: 357387
> 
> 
> Diffs
> -----
> 
>   applets/webbrowser/contents/config/main.xml PRE-CREATION 
>   applets/webbrowser/contents/ui/main.qml 3ebf120 
>   applets/webbrowser/metadata.desktop 222af48 
> 
> Diff: https://git.reviewboard.kde.org/r/126590/diff/
> 
> 
> Testing
> -------
> 
> Successfully restored after logout.
> Successfully restored after reboot.
> Each plasmoid is correctly restored in case there was more than 1 plasmoid.
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160101/3fee674b/attachment-0001.html>


More information about the Plasma-devel mailing list