Review Request 126590: [WebBrowser plasmoid] Remember last visited url and restore it on startup.

[Mihail Ivchenko]

> On Jan. 1, 2016, 9:22 p.m., David Edmundson wrote:
> > applets/webbrowser/contents/ui/main.qml, line 59
> > <https://git.reviewboard.kde.org/r/126590/diff/2/?file=428151#file428151line59>
> >
> >     this doesn't seem needed.
> >     
> >     
> >     urlField.text is already bound to webview.url on line 43

You are right, thanks.


On Jan. 1, 2016, 9:22 p.m., Mihail Ivchenko wrote:
> > Do you have commit access?

Yes, afaik I have. (I'm just still not sure if KDE Developer account grants commit access to most of public projects)


- Mihail


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126590/#review90405
-----------------------------------------------------------


On Jan. 1, 2016, 9:34 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126590/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2016, 9:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 357387
>     http://bugs.kde.org/show_bug.cgi?id=357387
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Remember last visited url and restore it on startup.
> BUG: 357387
> 
> 
> Diffs
> -----
> 
>   applets/webbrowser/contents/config/main.xml PRE-CREATION 
>   applets/webbrowser/contents/ui/main.qml 3ebf120 
>   applets/webbrowser/metadata.desktop 222af48 
> 
> Diff: https://git.reviewboard.kde.org/r/126590/diff/
> 
> 
> Testing
> -------
> 
> Successfully restored after logout.
> Successfully restored after reboot.
> Each plasmoid is correctly restored in case there was more than 1 plasmoid.
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160101/753ad9dc/attachment.html>