Review Request 127226: Theme: Discard pixmap cache when changing theme

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127226/
-----------------------------------------------------------

(Updated March 1, 2016, 12:10 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 60af310cfc456558648c9af73d35c8a7dbee3011 by David Rosca to branch master.


Bugs: 359924
    http://bugs.kde.org/show_bug.cgi?id=359924


Repository: plasma-framework


Description
-------

Changing theme also changes color scheme making the pixmap cache invalid for monochrome icons.


Diffs
-----

  src/plasma/private/theme_p.cpp cca11f3 

Diff: https://git.reviewboard.kde.org/r/127226/diff/


Testing
-------

This makes the latest IconItem test (themeChange) pass.

There doesn't seem to be issue with this in plasmashell, because when changing theme from KCM, the application palette gets changed too (and pixmap cache is discarded on QEvent::ApplicationPaletteChange). But when only changing the theme with Plasma::Theme::setThemeName there is no palette change.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/9b7a218b/attachment-0001.html>