Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell

[Kai Uwe Broulik]

> On Feb. 29, 2016, 9:52 nachm., Kai Uwe Broulik wrote:
> > Isn't that what
> > 
> > QCoreApplication::setAttribute(Qt::AA_DisableHighDpiScaling);
> >     
> > is supposed to do?
> 
> Xuetian Weng wrote:
>     Emm.. I'm checking if I was running the correct plasmashell...
> 
> Xuetian Weng wrote:
>     Ah, ok. So the real problem is QT_SCALE_FACTOR.
>     
>     It will do some work regardless of AA_DisableHighDpiScaling. So do we want to keep it always unset?

I would consider this a Qt (documentation?) bug:

"The application attribute Qt::AA_DisableHighDpiScaling, introduced in Qt 5.6, turns off all scaling. This is intended for applications that need to use actual window system coordinates, regardless of environment variables."

It explicitly mentions the env variables but yeah better safe than sorry, I guess KWin and KRunner need the same treatment.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127227/#review92941
-----------------------------------------------------------


On Feb. 29, 2016, 9:50 nachm., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127227/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 9:50 nachm.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Qt 5.6 introduces 3 new env variable for control high dpi scaling. unset them just like QT_DEVICE_PIXEL_RATIO.
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp d9963aa 
> 
> Diff: https://git.reviewboard.kde.org/r/127227/diff/
> 
> 
> Testing
> -------
> 
> On 5.6.0RC, I get some strange font size in plasmashell with it set, and quite a lot of size is not correct. Attach some screenshot for a idea. Looks like we are not ready for it yet.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160229_134832.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/29/b7cda20b-fe0c-4bd8-a674-54d87bc5ccdf__Screenshot_20160229_134832.png
> Screenshot_20160229_134846.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/29/4116c15c-393a-4885-bef9-78c9ab92ab37__Screenshot_20160229_134846.png
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/3106115f/attachment.html>