Review Request 127226: Theme: Discard pixmap cache when changing theme
David Rosca
nowrep at gmail.com
Mon Feb 29 21:49:59 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127226/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-framework
Description
-------
Changing theme also changes color scheme making the pixmap cache invalid for monochrome icons.
Diffs
-----
src/plasma/private/theme_p.cpp cca11f3
Diff: https://git.reviewboard.kde.org/r/127226/diff/
Testing
-------
This makes the latest IconItem test (themeChange) pass.
There doesn't seem to be issue with this in plasmashell, because when changing theme from KCM, the application palette gets changed too (and pixmap cache is discarded on QEvent::ApplicationPaletteChange). But when only changing the theme with Plasma::Theme::setThemeName there is no palette change.
Thanks,
David Rosca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/272811a0/attachment.html>
More information about the Plasma-devel
mailing list