Review Request 127218: properties for configurationRequired/configurationRequiredReason
Marco Martin
notmart at gmail.com
Mon Feb 29 13:24:05 UTC 2016
> On Feb. 29, 2016, 1:18 p.m., Kai Uwe Broulik wrote:
> > src/plasma/applet.h, line 463
> > <https://git.reviewboard.kde.org/r/127218/diff/2/?file=446008#file446008line463>
> >
> > Better explain the parameter reason here rather than in the getter
the text for reason is just copypasted in both places
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127218/#review92902
-----------------------------------------------------------
On Feb. 29, 2016, 12:39 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127218/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 12:39 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> unbreak api of Applet::SetConfigurationRequired + add bindings to appletInterface as properties.
>
>
> It would still need somewhere the creation of graphics for that, probably in the containments code.
>
>
> Diffs
> -----
>
> src/plasma/applet.h df57e94
> src/plasma/applet.cpp 4ce2d28
> src/plasma/private/applet_p.h e1aaef6
> src/plasma/private/applet_p.cpp 949c92e
> src/scriptengines/qml/plasmoid/appletinterface.h 8dcac08
> src/scriptengines/qml/plasmoid/appletinterface.cpp 550438d
>
> Diff: https://git.reviewboard.kde.org/r/127218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/4cfaba82/attachment.html>
More information about the Plasma-devel
mailing list