Review Request 127218: properties for configurationRequired/configurationRequiredReason
Kai Uwe Broulik
kde at privat.broulik.de
Mon Feb 29 13:20:34 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127218/#review92905
-----------------------------------------------------------
src/scriptengines/qml/plasmoid/appletinterface.cpp (line 655)
<https://git.reviewboard.kde.org/r/127218/#comment63368>
Remove this one, you emit it when configuration required changed is emitted in the applet
- Kai Uwe Broulik
On Feb. 29, 2016, 12:39 nachm., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127218/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 12:39 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> unbreak api of Applet::SetConfigurationRequired + add bindings to appletInterface as properties.
>
>
> It would still need somewhere the creation of graphics for that, probably in the containments code.
>
>
> Diffs
> -----
>
> src/plasma/applet.h df57e94
> src/plasma/applet.cpp 4ce2d28
> src/plasma/private/applet_p.h e1aaef6
> src/plasma/private/applet_p.cpp 949c92e
> src/scriptengines/qml/plasmoid/appletinterface.h 8dcac08
> src/scriptengines/qml/plasmoid/appletinterface.cpp 550438d
>
> Diff: https://git.reviewboard.kde.org/r/127218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/7d103f29/attachment-0001.html>
More information about the Plasma-devel
mailing list