Review Request 127218: properties for configurationRequired/configurationRequiredReason

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127218/#review92902
-----------------------------------------------------------




src/plasma/applet.h (line 463)
<https://git.reviewboard.kde.org/r/127218/#comment63365>

    Better explain the parameter reason here rather than in the getter



src/scriptengines/qml/plasmoid/appletinterface.h (line 355)
<https://git.reviewboard.kde.org/r/127218/#comment63367>

    bool required, not hide



src/scriptengines/qml/plasmoid/appletinterface.cpp (line 644)
<https://git.reviewboard.kde.org/r/127218/#comment63366>

    I think this is not optimal overall:
    
    Imagine you set both properties from QML:
    
    setConfigurationRequired(configuring, {});
    emits conf required changed in applet
    emits both changed
    
    setConfigurationRequired(same, reason);
    emits conf required changed in applet
    emits both changed again
    
    but whatever.. :)


- Kai Uwe Broulik


On Feb. 29, 2016, 12:39 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127218/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 12:39 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> unbreak api of Applet::SetConfigurationRequired + add bindings to appletInterface as properties.
> 
> 
> It would still need somewhere the creation of graphics for that, probably in the containments code.
> 
> 
> Diffs
> -----
> 
>   src/plasma/applet.h df57e94 
>   src/plasma/applet.cpp 4ce2d28 
>   src/plasma/private/applet_p.h e1aaef6 
>   src/plasma/private/applet_p.cpp 949c92e 
>   src/scriptengines/qml/plasmoid/appletinterface.h 8dcac08 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 550438d 
> 
> Diff: https://git.reviewboard.kde.org/r/127218/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/3b60918a/attachment.html>